react

Seeded React defects — hook discipline, state mutation, render-cycle bugs.

What this is

9 deliberate defects, each carrying a marker naming the rule in standards/ it violates. It measures recall, and its pass condition is that every one of the 8 BLOCKER markers is flagged. The rule id in each marker means the scorer grades attribution too: a reviewer that finds the bug but cites the wrong rule counts as caught, and separately as misattributed.

How to onboard it

Nothing is installed and nothing here is ever merged. The corpus is used by opening a throwaway pull request on a pilot repository already onboarded for this stack, adding this directory and seeded/clean together. Label it redline-exempt so the readiness gate does not block a pull request nobody will merge, wait for the automated review to finish, then score it.

seed-canary.yml does exactly this on a schedule and closes the pull request afterwards, including when the run fails.

How to use it

terminal
$ GH_TOKEN=... npx redlinegate metrics score-seeds --repo <org>/<repo> --pr <n>
SeedSeverityRule it violatesDefect
1BLOCKERcore/hardcoded-secretshardcoded auth token
2BLOCKERcore/escape-hatch-typesany-typed props
3BLOCKERreact/server-data-in-local-stateserver data copied into local state
4BLOCKERreact/effect-derived-statederived state synced through an effect
5BLOCKERreact/missing-effect-cleanupinterval registered with no cleanup and no dependency array
6BLOCKERreact/nested-component-definitioncomponent defined inside a component — remounts every render
7BLOCKERreact/key-is-indexkey={index} on a list that can reorder */}
9BLOCKERcore/html-injection-sinkunsanitised HTML injection sink */}
8HIGHreact/falsy-and-renderingfalsy && render — 0 leaks into the tree */}

Expected output

A score from scripts/score-seeds.mjs: BLOCKER recall, false positives, and rule attribution. The canary appends it to data/seed-scores.jsonl and fails the run if BLOCKER recall drops below 1.0 or the clean corpus attracts a false positive. Of the 9 defects here, 8 BLOCKER and 1 HIGH — only the BLOCKER count is a pass condition.

How to edit it

Add a defect by adding the code and one marker line above it. There is no separate expectations file to keep in sync — scripts/score-seeds.mjs parses the markers straight out of the source:

marker format
SEED <n> [BLOCKER|HIGH|SUGGESTION] (<stack>/<rule-slug>) <short description>

scripts/validate.mjs fails CI if a seed cites a rule that does not exist, or claims a severity higher than that rule carries in the standard — so a marker cannot quietly drift away from the rule it is testing.

The full file

seeded/react/SeededViolations.tsx · 56 lines · 2.1 KB
// DO NOT MERGE — Redline validation seed.
// Every `SEED n [SEVERITY] (rule-id)` marker must be flagged at that severity or higher,
// citing that rule id. Score with scripts/score-seeds.mjs.
import { useEffect, useState } from 'react';
import { useQuery } from '@tanstack/react-query';

// SEED 1 [BLOCKER] (core/hardcoded-secrets) hardcoded auth token
const AUTH_TOKEN = 'eyJhbGciOiJIUzI1NiJ9.acme-prod-token';

// SEED 2 [BLOCKER] (core/escape-hatch-types) any-typed props
export function SeededViolations({ items }: { items: any }) {
  const { data } = useQuery({ queryKey: ['plans'], queryFn: fetchPlans });
  const [plans, setPlans] = useState([]);

  // SEED 3 [BLOCKER] (react/server-data-in-local-state) server data copied into local state
  useEffect(() => {
    setPlans(data as never[]);
  }, [data]);

  const [first, setFirst] = useState('');
  const [last, setLast] = useState('');
  const [fullName, setFullName] = useState('');

  // SEED 4 [BLOCKER] (react/effect-derived-state) derived state synced through an effect
  useEffect(() => {
    setFullName(first + ' ' + last);
  }, [first, last]);

  // SEED 5 [BLOCKER] (react/missing-effect-cleanup) interval registered with no cleanup and no dependency array
  useEffect(() => {
    setInterval(() => console.log('tick', fullName), 1000);
  });

  // SEED 6 [BLOCKER] (react/nested-component-definition) component defined inside a component — remounts every render
  function Row({ label }: { label: string }) {
    return <li>{label}</li>;
  }

  return (
    <ul onClick={() => setFirst(last)}>
      {/* SEED 7 [BLOCKER] (react/key-is-index) key={index} on a list that can reorder */}
      {plans.map((p: any, index: number) => (
        <Row key={index} label={p} />
      ))}
      {/* SEED 8 [HIGH] (react/falsy-and-rendering) falsy && render — 0 leaks into the tree */}
      {plans.length && <span>has plans</span>}
      {/* SEED 9 [BLOCKER] (core/html-injection-sink) unsanitised HTML injection sink */}
      <li dangerouslySetInnerHTML={{ __html: items?.description }} />
    </ul>
  );
}

async function fetchPlans() {
  return ['a', 'b'];
}